Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web push client always needs 'Push Admin' capability. #1846

Open
sdg9670f opened this issue Aug 16, 2024 · 2 comments
Open

Web push client always needs 'Push Admin' capability. #1846

sdg9670f opened this issue Aug 16, 2024 · 2 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed. push-notifications Support for receiving push notifications in runtime environments that support that capability.

Comments

@sdg9670f
Copy link

sdg9670f commented Aug 16, 2024

When a web client tries to register a worker, the client must send a request to /push/publicVapidKey. The response was a 401 error

{
	"error": {
		"message": "action not permitted, app = PgluIg",
		"code": 40160,
		"statusCode": 401,
		"nonfatal": false,
		"href": "https://help.ably.io/error/40160",
		"serverId": "frontend.7d6a.2.ap-southeast-1-A.i-06841de5220e02174.a2dzMIR8QBfHVr"
	}
}

I discovered that the API requires 'Push Admin' capability.
so, Web push always requires 'Push Admin' capability.

I think it's too much permission for the client.

┆Issue is synchronized with this Jira Task by Unito

@sacOO7 sacOO7 added investigate push-notifications Support for receiving push notifications in runtime environments that support that capability. labels Aug 16, 2024
@ttypic
Copy link
Collaborator

ttypic commented Aug 16, 2024

Hey @sdg9670f,

Thank you very much for reporting this! I can confirm that it’s not correct. We are working on a fix, and I’ll let you know once it’s rolled out

@ttypic ttypic added bug Something isn't working. It's clear that this does need to be fixed. and removed investigate labels Aug 19, 2024
@ttypic
Copy link
Collaborator

ttypic commented Aug 28, 2024

The fix is implemented on our backend and will be rolled out early next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working. It's clear that this does need to be fixed. push-notifications Support for receiving push notifications in runtime environments that support that capability.
Development

No branches or pull requests

3 participants