Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm that client is unable to send data before verifying server identity #400

Open
lawrence-forooghian opened this issue Apr 25, 2024 · 0 comments
Labels
investigate Requires further investigation to decide the most appropriate label(s).

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 25, 2024

Our implementation of verification of the server’s TLS certificate is performed after the TLS handshake completes. Make sure that there’s no way that we might be sending any data to the server before verifying the certificate.

This applies to both the WebSocket code contained in this repo, and the HTTP code contained in https://github.com/ably-forks/em-http-request; they contain the same verification logic.

┆Issue is synchronized with this Jira Task by Unito

@lawrence-forooghian lawrence-forooghian added the bug Something isn't working. It's clear that this does need to be fixed. label Apr 25, 2024
@lawrence-forooghian lawrence-forooghian self-assigned this Apr 25, 2024
@lawrence-forooghian lawrence-forooghian added investigate Requires further investigation to decide the most appropriate label(s). and removed bug Something isn't working. It's clear that this does need to be fixed. labels Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
investigate Requires further investigation to decide the most appropriate label(s).
Development

No branches or pull requests

1 participant