Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket code has same incorrect server certificate verification logic as em-http-request #401

Open
lawrence-forooghian opened this issue Apr 25, 2024 · 2 comments
Open

WebSocket code has same incorrect server certificate verification logic as em-http-request #401

lawrence-forooghian opened this issue Apr 25, 2024 · 2 comments
Labels
bug Something isn't working. It's clear that this does need to be fixed.

Comments

@lawrence-forooghian
Copy link
Collaborator

lawrence-forooghian commented Apr 25, 2024 •
edited
Loading

The issue described in #396 also exists in our WebSocket code (although it's not currently causing a test failure since we don’t use Let’s Encrypt on our WebSocket endpoint). Fix it.

┆Issue is synchronized with this Jira Task by Unito
@lawrence-forooghian lawrence-forooghian added the bug Something isn't working. It's clear that this does need to be fixed. label Apr 25, 2024
@lawrence-forooghian lawrence-forooghian self-assigned this Apr 25, 2024
@sacOO7
Copy link
Contributor

sacOO7 commented Jun 5, 2024

Seems similar issue was patched as a part of #234

@lawrence-forooghian
Copy link
Collaborator Author

I might be missing something but I think that #234 just pulls in the verification logic from em-http-request, i.e. the incorrect logic described in #396?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working. It's clear that this does need to be fixed.
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sacOO7 @lawrence-forooghian