improve search #62
Open
improve search #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Update stats wording after the search. 2. Search box only searches for the license key or license name. 3. Showing search box on all pages Reference: aboutcode-org#58 Signed-off-by: Alok Kumar <[email protected]>
alok1304
force-pushed
the
improve_search
branch
from
cd740e4 to
81655f3
Compare
|
@pombredanne can you please review this PR : ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58
Task:
Linkscolumn #48I use the column-specific search API provided by DataTables. (source: https://datatables.net/reference/api/search())
Override applied in
static/jquery.mark-8.11.1.min.jsto ensure the visibility of the search section.Adding this
#search-section {display: flex !important;}in filestatic/jquery.mark-8.11.1.min.js.Reference: #58
Also I attach my work in screenshot before and after.
We can clearly see that in 1st screenshot it shows Showing 1 to 376 of 376 licenses. On 2nd screenshot we see that it shows Showing 51 licenses. Also we can see that here license is 51 because we only search for license key and name, not for all.