Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate IpAddresses of session. #20794

Closed
maliming opened this issue Sep 12, 2024 · 2 comments · Fixed by #20819
Closed

Truncate IpAddresses of session. #20794

maliming opened this issue Sep 12, 2024 · 2 comments · Fixed by #20819
Assignees
Milestone

Comments

@maliming
Copy link
Member

Also add the length of IdentitySessionConsts.MaxIpAddressesLength.

@maliming maliming self-assigned this Sep 12, 2024
@maliming maliming added this to the 9.0-preview milestone Sep 12, 2024
@colinin
Copy link

colinin commented Sep 16, 2024

How to record the region where the login ip address is located? for example: 180.168.255.18 from Shanghai,

public class IdentitySession : BasicAggregateRoot<Guid>, IMultiTenant
{
    public virtual string Region { get; protected set; }
    // ...
}

or an IdentitySession entity inherited from IHasExtraProperties

public class IdentitySession : BasicAggregateRoot<Guid>, IHasExtraProperties, IMultiTenant
{
    public ExtraPropertyDictionary ExtraProperties { get; protected set; }
    // ...
}

This is optional. Users can implement IP address resolution by themselves, such as IP2Region

@maliming
Copy link
Member Author

How to record the region where the login ip address is located? for example: 180.168.255.18 from Shanghai,

public class IdentitySession : BasicAggregateRoot<Guid>, IMultiTenant
{
    public virtual string Region { get; protected set; }
    // ...
}

or an IdentitySession entity inherited from IHasExtraProperties

public class IdentitySession : BasicAggregateRoot<Guid>, IHasExtraProperties, IMultiTenant
{
    public ExtraPropertyDictionary ExtraProperties { get; protected set; }
    // ...
}

This is optional. Users can implement IP address resolution by themselves, such as IP2Region

#20771

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants