SMQ-2633 - Fix create users #215
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nyagamunene <[email protected]>
Musilah
reviewed
Jan 7, 2025
docs/cli.md
Outdated
| @@ -174,9 +174,9 @@ For "things" service, the response should look like this: | |||
| SuperMQ has two options for user creation. Either the `<user_token>` is provided or not. If the `<user_token>` is provided then the created user will be owned by the user identified by the `<user_token>`. Otherwise, when the token is not used, since everybody can create new users, the user will not have an owner. However, the token is still required, in order to be consistent. For more details, please see [Authorization page](authorization.md). | |||
|
|
|||
| ```bash | |||
| supermq-cli users create <user_name> <user_email> <user_password> | |||
| supermq-cli users create <first_name> <last_name> <user_email> <user_name> <user_password> | |||
There was a problem hiding this comment.
Use username instead of user_name
Signed-off-by: nyagamunene <[email protected]>
JeffMboya
previously approved these changes
Jan 7, 2025
JeffMboya
reviewed
Jan 7, 2025
| @@ -174,9 +174,9 @@ For "things" service, the response should look like this: | |||
| SuperMQ has two options for user creation. Either the `<user_token>` is provided or not. If the `<user_token>` is provided then the created user will be owned by the user identified by the `<user_token>`. Otherwise, when the token is not used, since everybody can create new users, the user will not have an owner. However, the token is still required, in order to be consistent. For more details, please see [Authorization page](authorization.md). | |||
|
|
|||
| ```bash | |||
| supermq-cli users create <user_name> <user_email> <user_password> | |||
| supermq-cli users create <first_name> <last_name> <user_email> <username> <user_password> | |||
There was a problem hiding this comment.
You could add a complete example below this
Suggested change
| supermq-cli users create <first_name> <last_name> <user_email> <username> <user_password> | |
| supermq-cli users create <first_name> <last_name> <user_email> <username> <user_password> |
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
JeffMboya
previously approved these changes
Jan 7, 2025
Musilah
previously approved these changes
Jan 7, 2025
Signed-off-by: nyagamunene <[email protected]>
Signed-off-by: nyagamunene <[email protected]>
Musilah
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request title should be
SMQ-XXX - descriptionorNOISSUE - descriptionwhere XXX is ID of issue that this PR relate to.Please review the CONTRIBUTING.md file for detailed contributing guidelines.
What does this do?
This is a bug fix because it fixes the issue with creating users.
Which issue(s) does this PR fix/relate to?
Resolves #2633
List any changes that modify/break current functionality
N/A
Have you included tests for your changes?
Yes
Did you document any new/modified functionality?
Notes