-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template Signature in ciceromark_parsed
#433
Comments
We would probably need something like this. My suggestion may be wrong because I don' clearly understand the difference between a clause and a contract. {
"$class": "org.accordproject.commonmark.Document",
"identfier": "[email protected]",
"xmlns": "http://commonmark.org/xml/1.0",
"nodes": [...]
} |
The |
If you need to generate a stable id for a clause then I suggest you compute an SHA hash of the textual content of the clause (text or JSON data as a string), including the template src (see above). See: https://www.nodejsera.com/snippets/nodejs/sha256-hash.html |
@dselman
I see that this is optional, so how is there any flag which we need to pass. |
I'm not sure I understand the requirement. What's an identifier in this context? If it's something specifically needed for OOXML, then Dan's suggestion to generate a hash from (ciceromark / the data / something else) makes sense to me. |
Feature Request 🛍️
Currently, the
ciceromark_parsed
does not contain the template signature. A template signature can be incorporated into theciceromark_parsed
to uniquely identify them.Use Case
This issue was raised with respect to #432. The major use is to uniquely identify the conversions
CiceroMark<->OOXML
.<w:sdt>
requires a unique id to distinguish itself. The template identifier can be used as this id.Context
While working on #432, there occurred a need to wrap the complete OOXML in
<w:sdt>
and hence an id was required. Randomly generating id causes test failure so this issue was created.Detailed Description
A field
template_signature
in the ciceromark_parsedThe text was updated successfully, but these errors were encountered: