Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing label in marker properties #175

Open
katharinawuensche opened this issue Oct 9, 2024 · 4 comments
Open

Missing label in marker properties #175

katharinawuensche opened this issue Oct 9, 2024 · 4 comments
Assignees
Labels

Comments

@katharinawuensche
Copy link
Member

Some features in the geojson data do not include a label entry in their properties dict, leading to an error in the geo-map component. Can the name field be used as a label in these cases?

@ctot-nondef
Copy link
Member

this should be solved on the data level - @simar0at will check with the product owners

currently the label is used for sorting

@kisram
Copy link
Contributor

kisram commented Nov 11, 2024

@katharinawuensche could you give me an example feature where this is the case?

@katharinawuensche
Copy link
Member Author

The Wibarab features look like this:

{
    "type": "Feature",
    "id": "geo:zintan+LBY-ZTN",
    "geometry": { "type": "Point", "coordinates": [12.252778, 31.931667] },
    "properties": {
      "ft_djim": {
        "ǧ → ž": {
          "examples": ["žəld"],
          "sources": {
            "caubet_2004_3508": {
              "decade_dc": { "1940s": "high" },
              "link": "http://zotero.org/groups/2165756/items/Z8BXD2S8",
              "short_cit": "Caubet2004e"
            }
          }
        }
      },      
      "name": "Zintan",
      "variety": "LBY-ZTN"
    }
  },

Whereas the features in Vicav have an additional label field that often seems to be the same as the name:

{
    "type": "Feature",
    "geometry": {
      "type": "Point",
      "coordinates": [35.06666666666667, 32.916666666666664]
    },
    "properties": {
      "type": "geo",
      "name": "Akko/Acre",
      "label": "Akko/Acre",
      "hitCount": 1,
      "textId": "profile_akkon_01",
      "targetType": "Profile"
    }
  }

This label is currently used for sorting markers in multiple projects which is why we would either need the corresponding property in our Wibarab data or agree to use the existing name property in the frontend if label is not available.

@kisram
Copy link
Contributor

kisram commented Nov 12, 2024

I think it's fine to use the name property if you only need it for sorting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants