Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FailedCivetOutput model #132

Open
prioux opened this issue Oct 2, 2018 · 1 comment
Open

Add FailedCivetOutput model #132

prioux opened this issue Oct 2, 2018 · 1 comment
Assignees
@prioux

Comments

@prioux
Copy link
Member

prioux commented Oct 2, 2018 •
edited
Loading

Sometimes when Civet fails, the user (often a dev) wants to investigate the reason why in more details. I suggest the post-processing step of Civet should create a new FailedCivetOutput < CivetOutput or FailedCivetOutput < FileCollection model and store the partial result in there. Advantage of < CivetOutput is that we can use the viewers defined in CivetOutput, but there should be a warning about (likely) missing files. So maybe use < FileCollection instead.
@prioux prioux self-assigned this Oct 2, 2018
@prioux
Copy link
Member Author

prioux commented Oct 2, 2018

If we make the model < CivetOutput, then we should also maybe include code in CivetCombiner to refuse them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prioux prioux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@prioux