Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sigma_los^2 caching from likelihood.py to disperion.py #4

Open
achiappo opened this issue Jun 29, 2017 · 0 comments
Open

move sigma_los^2 caching from likelihood.py to disperion.py #4

achiappo opened this issue Jun 29, 2017 · 0 comments

Comments

@achiappo
Copy link
Owner

The current instructions to cache the value of sigma_los^2 in likelihood.py (ll 23-33) are not enabled, even because caching at this stage is pointless, since every parameter changes value at this point. I, therefore, suggest moving these instructions to dispersion.py module. I would do the following:
create two separate cache containers, one for integral (the integral of M(s/r0) nu(s/rh) Ker(s,ra-beta), so where most running variables enter) and one for the surface brightness. The latter, in particular, never changes when the stellar density parameters are fixed.
In this way all three terms (integral , self.stellar.surface_brightness(R) , Jred) are treated in the same way and all values are cached

@achiappo achiappo reopened this Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant