Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image assets in Github #255

Open
ace-n opened this issue Sep 6, 2014 · 7 comments
Open

Image assets in Github #255

ace-n opened this issue Sep 6, 2014 · 7 comments
Labels

Comments

@ace-n
Copy link
Contributor

ace-n commented Sep 6, 2014

Do we need these images in here? Each of these is ~13mb, and downloading them with git seems a little silly. (Maybe offload them to AFS or store them outside of git on the server somehow?)

https://github.com/acm-uiuc/liquid/tree/master/liquid/static/img/conference

@ace-n ace-n added the wishlist label Sep 6, 2014
@achalv
Copy link
Member

achalv commented Sep 6, 2014

Always nice to have a retrievable history of static assets, IMO. It's come in handy a lot with the conference website for instance.

Anyone else want to chime in on this?

Sent from Mailbox

On Sat, Sep 6, 2014 at 1:11 AM, Ace Nassri [email protected]
wrote:

Do we need these images in here? Each of these is ~13mb, and downloading them with git seems a little silly. (Maybe offload them to AFS or store them outside of git on the server somehow?)

https://github.com/acm-uiuc/liquid/tree/master/liquid/static/img/conference

Reply to this email directly or view it on GitHub:
#255

@ace-n
Copy link
Contributor Author

ace-n commented Sep 6, 2014

I noticed that some of the n were assets were much smaller - around 1mb. I
might go through and see if losslessly compressing these helps at all.
On Sep 6, 2014 11:23 AM, "Achal Varma" [email protected] wrote:

Always nice to have a retrievable history of static assets, IMO. It's come
in handy a lot with the conference website for instance.

Anyone else want to chime in on this?

Sent from Mailbox

On Sat, Sep 6, 2014 at 1:11 AM, Ace Nassri [email protected]
wrote:

Do we need these images in here? Each of these is ~13mb, and downloading
them with git seems a little silly. (Maybe offload them to AFS or store
them outside of git on the server somehow?)

https://github.com/acm-uiuc/liquid/tree/master/liquid/static/img/conference

Reply to this email directly or view it on GitHub:
#255


Reply to this email directly or view it on GitHub
#255 (comment).

@colegleason
Copy link
Member

I don't think it will matter since they are already in the git history.

@ace-n
Copy link
Contributor Author

ace-n commented Sep 8, 2014

Yeah, that's what I was worried about. It might make the website faster
though (if/when they are used)...

On Mon, Sep 8, 2014 at 12:27 AM, Cole Gleason [email protected]
wrote:

I don't think it will matter since they are already in the git history.


Reply to this email directly or view it on GitHub
#255 (comment).

@ace-n
Copy link
Contributor Author

ace-n commented Sep 8, 2014

Maybe this would solve the problem?
http://rtyley.github.io/bfg-repo-cleaner/

On Mon, Sep 8, 2014 at 12:30 AM, Ace Nassri [email protected] wrote:

Yeah, that's what I was worried about. It might make the website faster
though (if/when they are used)...

On Mon, Sep 8, 2014 at 12:27 AM, Cole Gleason [email protected]
wrote:

I don't think it will matter since they are already in the git history.


Reply to this email directly or view it on GitHub
#255 (comment).

@brendanjryan
Copy link
Member

idk if these images are used anywhere..

@colegleason
Copy link
Member

Yeah I would rather use filter-branch to remove them. However, if we are using an image on the site it should be included in Git, IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants