Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Black for actinia #372

Closed
anikaweinmann opened this issue Aug 3, 2022 · 5 comments
Closed

Black for actinia #372

anikaweinmann opened this issue Aug 3, 2022 · 5 comments
Labels

Comments

@anikaweinmann
Copy link
Member

anikaweinmann commented Aug 3, 2022

We want to use black to beautify actinia code.

We want to use some black in Workflows, so that workflows fails if the code is not black conform.
Before the workflow is active we need to do black about the whole code.

@neteler
Copy link
Member

neteler commented Aug 3, 2022

FYI, here the related GRASS GIS black workflow:

https://github.com/OSGeo/grass/blob/main/.github/workflows/black.yml

@anikaweinmann
Copy link
Member Author

@mmacata
Copy link
Member

mmacata commented Nov 29, 2022

From my point of view, megalinter is also fine, but I don't know if this would also change files like black does. I would suggest to not add black there and see how we get along with megalinter!?

@anikaweinmann
Copy link
Member Author

Linting in GHA and pre-commits should be added for actinia-core and Plugins; see https://github.com/mundialis/github-workflows

@mmacata
Copy link
Member

mmacata commented Aug 30, 2023

See #469 (maybe close this one here)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants