Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ssh-keygen not presented #2152

Closed
7 tasks done
sspakush opened this issue Jan 13, 2023 · 9 comments
Closed
7 tasks done

Ssh-keygen not presented #2152

sspakush opened this issue Jan 13, 2023 · 9 comments
Labels
bug Something isn't working needs triage Requires review from the maintainers

Comments

@sspakush
Copy link

Checks

Controller Version

2.300.2

Helm Chart Version

v0.21.0

CertManager Version

1.9.1

Deployment Method

Helm

cert-manager installation

yes

Checks

  • This isn't a question or user support case (For Q&A and community support, go to Discussions. It might also be a good idea to contract with any of contributors and maintainers if your business is so critical and therefore you need priority support
  • I've read releasenotes before submitting this issue and I'm sure it's not due to any recently-introduced backward-incompatible changes
  • My actions-runner-controller version (v0.x.y) does support the feature
  • I've already upgraded ARC (including the CRDs, see charts/actions-runner-controller/docs/UPGRADING.md for details) to the latest and it didn't fix the issue
  • I've migrated to the workflow job webhook event (if you using webhook driven scaling)

Resource Definitions

apiVersion: actions.summerwind.dev/v1alpha1
kind: RunnerSet
spec:
  organization: org
  dockerEnabled: true
  dockerMTU: 1300
#  dockerdWithinRunnerContainer: true
  labels:
    - docker-runner
  # Other mandatory fields from StatefulSet
  selector:
    matchLabels:
      app: runners
  serviceName: runners
  template:
    metadata:
      labels:
        app: runners

To Reproduce

add action with ssh keys

Describe the bug

We use an actions with ssh-keygen.
After migration to runners v2.300.2 we face a problem: "Error: Unable to locate executable file: ssh-keygen. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable."

Describe the expected behavior

I believe that need to add ssh-keygen package

Whole Controller Logs

Logs in controller are of no interest

Whole Runner Pod Logs

Logs in controller are of no interest

Additional Context

Github action log:
Error: Error: Unable to locate executable file: ssh-keygen. Please verify either the file path exists or the file can be found within a directory specified by the PATH environment variable. Also check the file mode to verify the file is executable.

@sspakush sspakush added bug Something isn't working needs triage Requires review from the maintainers labels Jan 13, 2023
@github-actions
Copy link
Contributor

Hello! Thank you for filing an issue.

The maintainers will triage your issue shortly.

In the meantime, please take a look at the troubleshooting guide for bug reports.

If this is a feature request, please review our contribution guidelines.

@sspakush
Copy link
Author

UPD. ssh package is not presented too. Could you add it to images?

@yoshz
Copy link

yoshz commented Jan 13, 2023

Same here with ssh-agent. All our pipelines are broken now.

@raffis
Copy link

raffis commented Jan 13, 2023

What actually happened is that :latest points now to the ubuntu 22.04 image and not 20.04. That image does not contain ssh packages, also some other things are different like the $PATH var and likely many other things.
Also broke many of our actions.

A quick workaround is to pin the runners to the v20.04 version.

See #2056

@sspakush
Copy link
Author

@yoshz we performed rollback to image: summerwind/actions-runner:v2.299.1-ubuntu-20.04 and pipelines works well but it's a temporary fix...

@yoshz
Copy link

yoshz commented Jan 13, 2023

@sspakush That indeed works. But based on @raffis comment I switched to summerwind/actions-runner:ubuntu-20.04 as the problem is indeed that latest is pointing to summerwind/actions-runner:ubuntu-22.04.

@raffis
Copy link

raffis commented Jan 13, 2023

@sspakush That indeed works. But based on @raffis comment I switched to summerwind/actions-runner:ubuntu-20.04 as the problem is indeed that latest is pointing to summerwind/actions-runner:ubuntu-22.04.

That works, just adding here that it seems that summerwind/actions-runner:ubuntu-20.04 does not point to the latest version,
summerwind/actions-runner:v2.300.2-ubuntu-20.04 would be the latest working 20.04 version. Seems there is no moving tag anymore for 20.04 (neither for 22.04).

@sspakush
Copy link
Author

@yoshz @raffis you are right, but I preferred to fix also the version. Just in case =)

@Link-
Copy link
Member

Link- commented Jan 18, 2023

For everyone in this thread, latest tag is deprecated and will be removed.

#2056

Even though the tag was applied by mistake as we migrated the workflows, please use a more specific version of the runner tag in your setups.

I'm closing this issue now as the conversation for what to include in the ubuntu-22.04 image is still open: #2098 (comment)

@Link- Link- closed this as completed Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working needs triage Requires review from the maintainers
Projects
None yet
Development

No branches or pull requests

4 participants