Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with yarn workspaces builds on Ubuntu 22.04.5 #10655

Closed
4 of 13 tasks
joshcasey-aderant opened this issue Sep 19, 2024 · 2 comments
Closed
4 of 13 tasks

Issues with yarn workspaces builds on Ubuntu 22.04.5 #10655

joshcasey-aderant opened this issue Sep 19, 2024 · 2 comments

Comments

@joshcasey-aderant
Copy link

joshcasey-aderant commented Sep 19, 2024

Description

After latest build of images, when building in a focused workspace using yarn workspaces focus --production and tsc build our builds fail due to building test files that are not included in our production build.

There has been no code changes, only noticeable change is the runners version change from 22.04.4 to 22.04.5

On the same commit, builds pass when operating system is Ubuntu 22.04.4, however now fail, on Ubuntu 22.04.5

Have attempted all the new Ubuntu images and the problem persists.

Any ideas?

Platforms affected

  • Azure DevOps
  • GitHub Actions - Standard Runners
  • GitHub Actions - Larger Runners

Runner images affected

  • Ubuntu 20.04
  • Ubuntu 22.04
  • Ubuntu 24.04
  • macOS 12
  • macOS 13
  • macOS 13 Arm64
  • macOS 14
  • macOS 14 Arm64
  • Windows Server 2019
  • Windows Server 2022

Image version and build link

Image: ubuntu-22.04
Version: 20240915.1.0
Included Software: https://github.com/actions/runner-images/blob/ubuntu22/20240[9](https://github.com/aderant/cloud-ar/actions/runs/10948609866/job/30400008973#step:1:10)15.1/images/ubuntu/Ubuntu2204-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/ubuntu22%2F20240915.1

Is it regression?

Yes

Expected behavior

Builds do not build test files after the dev dependencies are removed.

Actual behavior

Builds are building code paths that should not be being built after a workspace focus on yarn

Repro steps

Using yarn workspaces focus --production and tsc build, build project.

@aderant-smcd
Copy link

aderant-smcd commented Sep 19, 2024

Looks like this is (probably) caused by a newer tsc version being stricter about some dependency issues, will update with full cause later - if anyone else is getting issues with typescript projects using yarn workspaces on the latest ubuntu runners try making your builds use tsc 5.1.3.

@joshcasey-aderant
Copy link
Author

As above ^, we had to downgrade our TS Version on the runner as we had some compilation issues due to the newer version of TSC and this also exposed some dependency issues which required resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants