Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Utilize the.tool-versions file to set expected Go version #375

Open
plukevdh opened this issue May 19, 2023 · 6 comments · May be fixed by #402 or #295
Open

feat: Utilize the.tool-versions file to set expected Go version #375

plukevdh opened this issue May 19, 2023 · 6 comments · May be fixed by #402 or #295
Assignees
@dsame
Labels
feature request New feature or request to improve the current logic

Comments

@plukevdh
Copy link

plukevdh commented May 19, 2023 •
edited
Loading

Description:
It would be useful to utilize the .tool-versions file to set the expect version of Go for the action runtime in addition to being able to set via the parameters.

Justification:
Because an action may be used across a variety of steps, it can be burdensome to track the Go version via the parameter in every place used. Several other setup-<lang> projects are also utilizing or making progress towards using the .tool-versions file for version locking.

Are you willing to submit a PR?
💯 if this feels like a thing that would be useful to the community and in keeping with the goal of this project.
@plukevdh plukevdh added feature request New feature or request to improve the current logic needs triage labels May 19, 2023
@plukevdh plukevdh mentioned this issue May 19, 2023
Closed
2 tasks
@IvanZosimov
Copy link
Contributor

Hi, @plukevdh 👋 Thanks for the feature request, we will take a look and get back to you with updates.

@plukevdh
Copy link
Author

@IvanZosimov thanks! Note that I also opened a PR for this feature as well with some initial ideas: #376

@steebchen
Copy link

This would be awesome to have, the setup-node action also supports this 👍

- uses: actions/setup-node@v3
  with:
    # ...
    # File containing the version Spec of the version to use.  Examples: .nvmrc, .node-version, .tool-versions.
    # If node-version and node-version-file are both provided the action will use version from node-version. 
    node-version-file: ''

https://github.com/actions/setup-node#usage

@dsame dsame self-assigned this Jul 27, 2023
@dsame dsame linked a pull request Jul 27, 2023 that will close this issue
Open
2 tasks
@dsame dsame linked a pull request Jul 27, 2023 that will close this issue
Utilize the .tool-versions file to set expected Go version #402
Open
2 tasks
This was linked to pull requests Aug 15, 2023
Parse .tool-versions file to determine Go version #376
Closed
docs: go-version-file for other use cases #295
Open
@dsame
Copy link
Contributor

dsame commented Aug 16, 2023

Hello @plukevdh , thank you for your contribution, but i would ask you to review this PR as well #402 - do you see any drawbacks of using the existing go-version-file input instead of introducing new one tool-versions-file https://github.com/actions/setup-go/pull/376/files#diff-b97cd7a3fa566070832c220ba3fab8e4f60694550f6fe74d6024a20486165de8R148 ?

@plukevdh
Copy link
Author

@dsame Happy to close this in favor of #402 since it's a simpler solve.

@dsame
Copy link
Contributor

dsame commented Aug 17, 2023

Hello @plukevdh , thank you for assistance to make a choice between #402 and #376, but i'll keep this issue open till #402 will have been merged

@dsame dsame reopened this Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dsame dsame

Labels
feature request New feature or request to improve the current logic
Projects
None yet
Milestone
No milestone
5 participants
@plukevdh @dsame @steebchen @IvanZosimov and others