From 5ac44822e6c485daa553e88e90ce6d46bc082484 Mon Sep 17 00:00:00 2001 From: Nathan Voxland Date: Wed, 11 Oct 2023 10:09:14 -0700 Subject: [PATCH 1/2] Disable huggingface tests on macos because they cause pyarrow incompatibility --- deeplake/integrations/tests/test_huggingface.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/deeplake/integrations/tests/test_huggingface.py b/deeplake/integrations/tests/test_huggingface.py index c153b3dd2a..b8b9bc4ed0 100644 --- a/deeplake/integrations/tests/test_huggingface.py +++ b/deeplake/integrations/tests/test_huggingface.py @@ -1,3 +1,12 @@ +import pytest +import sys + +if sys.platform == "darwin": + pytest.skip( + "skipping tests on macos due to issue with pyarrow + our aws usage https://github.com/aws/aws-sdk-cpp/issues/2411", + allow_module_level=True, + ) + from datasets import load_dataset # type: ignore from datasets import Dataset # type: ignore from deeplake.api.tests.test_api import convert_string_to_pathlib_if_needed @@ -6,7 +15,6 @@ from deeplake.util.exceptions import TensorAlreadyExistsError from numpy.testing import assert_array_equal -import pytest import deeplake From d35aab256fac7fd2b19a7b8fe10117fca88e370e Mon Sep 17 00:00:00 2001 From: Nathan Voxland Date: Wed, 11 Oct 2023 23:17:56 -0700 Subject: [PATCH 2/2] Fixed test-macos label for github action --- .github/workflows/test-push.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/test-push.yml b/.github/workflows/test-push.yml index bf22600a15..3e5143aab7 100644 --- a/.github/workflows/test-push.yml +++ b/.github/workflows/test-push.yml @@ -66,7 +66,7 @@ jobs: ] } - if "${{ contains(github.event.pull_request.labels.*.name, 'macos-tests') }}" == "true": + if "${{ contains(github.event.pull_request.labels.*.name, 'test-macos') }}" == "true": matrix["os"].append("macos-latest") if "${{ contains(github.event.pull_request.labels.*.name, 'full-tests') }}" == "true":