Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

acknowledge in ipay88 module does not work #114

Open
muhammadn opened this issue Jan 22, 2015 · 0 comments
Open

acknowledge in ipay88 module does not work #114

muhammadn opened this issue Jan 22, 2015 · 0 comments

Comments

@muhammadn
Copy link

The code below:

        def acknowledge
          secure? && (!success? || requery == "00")
        end

at:

https://github.com/Shopify/offsite_payments/blob/master/lib/offsite_payments/integrations/ipay88.rb

shouldn't it be:

        def acknowledge
          secure? && (success? || requery == "00")
        end

as the previous commiter set it as !success which i feel it is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant