Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finalize tests for page filter component #1051

Open
2 tasks done
andrewtavis opened this issue Dec 10, 2024 · 1 comment
Open
2 tasks done

Finalize tests for page filter component #1051

andrewtavis opened this issue Dec 10, 2024 · 1 comment
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

The page filter component is being added in #1027, but we'll likely need to merge this in without the tests being finalized due to a deadline. Copying over some of the comments from @cquinn540 so we know how to improve them, and maybe @Hasteerp would have interest in finalizing all this in the coming weeks :)

The comments on test improvements can be seen at the following links:

Contribution

Please let us know if you'd like to work on this, @Hasteerp!

@andrewtavis andrewtavis added the feature New feature or request label Dec 10, 2024
@andrewtavis andrewtavis added the help wanted Extra attention is needed label Dec 10, 2024
@andrewtavis
Copy link
Member Author

Similarly for the testing, it would be good if this component made use of GridFilterTags instead of BtnTag, with the latter being a component we already have :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

1 participant