Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

map: refactor to use localized strings within map controls/interactions #968

Closed
2 tasks done
wkyoshida opened this issue Sep 8, 2024 · 7 comments
Closed
2 tasks done
Assignees
Labels
design Relates to UX/UI designs help wanted Extra attention is needed

Comments

@wkyoshida
Copy link
Member

Terms

Description

Like elsewhere in the application, it would be good for the map controls/interactions to also make use of localized strings.

Contribution

Happy to support someone on this or get to it myself 😁

@akdave2003
Copy link
Contributor

Hi this is Ansh, Zach and I are ready to be assigned!

@andrewtavis
Copy link
Member

Nice! Thanks for writing in, @akdave2003 :) Let us know if there's anything we can do to support!

@akdave2003
Copy link
Contributor

Hey I had a question. So in the file I started out by refactoring these strings: FOOT, BIKE, DRIVING, CAR. I also added the corresponding variables to the json file. My partner and I were wondering, would this apply to every string in the file or are there some strings we should leave alone. For example, there are two strings called api and profile, do those need to be refactored?

@andrewtavis
Copy link
Member

Those would not need to be refactored, @akdave2003 :) The big thing is that we need Change profile also localized, as well as hosted by :) Those look to be the main ones that are needed 😊

@andrewtavis
Copy link
Member

The API request is coming out of the component anyway, and it will be replaced with loading in the event object and then gettin the bounding box, latitude and longitude from it :)

@andrewtavis
Copy link
Member

Hey @akdave2003 👋 I just did some major changes to how events work, so I'd suggest pulling them in. You can now navigate to an event page and see the results of your localized controls via View events on the development home screen and then selecting an event 😊

Please let us know if there's anything that we can do to support!

@andrewtavis
Copy link
Member

Closing this issue because of the work in #1045, with further work to localize the preloaded Maplibre GL GS controls happening in #1071 :)

Thanks for the great contribution, @akdave2003! Hope we can work with you again soon :)

@github-project-automation github-project-automation bot moved this from Todo to Done in activist Board Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design Relates to UX/UI designs help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

3 participants