@paulgessinger I have question:

There is the line in check_format.sh that runs git diff:

If I run this with check_format_local.sh, the line makes an warning:

warning: Not a git repository. Use --no-index to compare two paths outside a working tree
usage: git diff --no-index [<options>] <path> <path>

I think I have seen this in Acts core as well, do you know how to bypass this? (Maybe adding an if condition which checks whether pwd is in git repository?)

@beomki-yeo I guess it depends if the mounted volume has .git in the directory hierarchy. If not it won't work I think.

On your personal machine you can just install clang-format, and in 99.999999% of the cases it will just work fine with the check_format.sh script.

Have you tested with other version of clang-format?
clang-format-10 is not easy to install these days and i believe our CI will break even with clang-format-11 if I remember correctly.

@beomki-yeo @krasznaa

1. Consider bumping the version once in a while
2. I usually grab statically compiled binaries from here: https://github.com/muttleyxd/clang-tools-static-binaries/releases/tag/master-8f72ab3c

As I wrote, on Ubuntu I only ever installed the default clang-format package, and that worked "pretty much" always the same as the version coming with the Docker image.

Admittedly I apparently spoke too quickly about RHEL9. Apparently on that I only ever used the Docker image. As I'm having a hard time finding a viable package for it on a vanilla system. 😦

But what always works for me, even on Windows: VS Code comes with a built-in code formatter. Which respects the project's .clang-format settings. So in 99% of the cases I just use the VS Code shortcut these days. And then do one big run with check_format.sh at the end of some bigger updates.