Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate csv geometry examples and their data #661

Open
beomki-yeo opened this issue Jul 30, 2024 · 3 comments
Open

Deprecate csv geometry examples and their data #661

beomki-yeo opened this issue Jul 30, 2024 · 3 comments

Comments

@beomki-yeo
Copy link
Contributor

I don't think they are useful anymore in traccc.
I suggest to cleanup the README instructions, relavant data and I/O codes.
@krasznaa @stephenswat How do you think?
@stephenswat
Copy link
Member

I think we still need the CSV data, but I agree that the CSV geometries can go.

@beomki-yeo
Copy link
Contributor Author

Yeah I was meaning the csv geometries only and data generated with csv geometries

@beomki-yeo beomki-yeo changed the title Deprecate csv geometry examples and data Deprecate csv geometry examples and their data Jul 30, 2024
@krasznaa
Copy link
Member

🤔 Let's talk about this today. As I've thought about this a fair amount wrt. #627. Removing the ability to read CSV geometry files is not going to get rid of nearly as much code as you might think. But it's easier if we discuss this in person...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stephenswat @krasznaa @beomki-yeo