Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fails on MacOs with Macports #13

Closed
WolfgangFahl opened this issue Aug 19, 2022 · 2 comments
Closed

fails on MacOs with Macports #13

WolfgangFahl opened this issue Aug 19, 2022 · 2 comments

Comments

@WolfgangFahl
Copy link

WolfgangFahl commented Aug 19, 2022

Environment

bash --version
GNU bash, version 5.1.16(1)-release (x86_64-apple-darwin17.7.0)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

Issue

qlever

Bash completion not activated or no Qleverfile exists or both. Please run the
qlever configuration once as follows (an existing Qleverfile will not be
overwritten, don't worry): 

. /Volumes/Quaxo/qlever/qlever-control/qlever

Afterwards you can just call "qlever" (without the dot and without specifying
the path). If you don't care about bash autocompletion or it doesn't work on
your system, set BASH_COMPLETION = 0 in your Qleverfile.

while i did change the bash completion setting

tail -2 Qleverfile 
# bash completion
BASH_COMPLETION = 0
@WolfgangFahl
Copy link
Author

It would IMHO be good to completely switch off the feature on the commandline by being able to specify the Qleverfile with a switch as most other unix scripts would allow to do. I tried to remove the culprit lines that try to do the magic of but that also didn' help

git diff qlever 
diff --git a/qlever b/qlever
index c9ee6c2..7d44ca1 100755
--- a/qlever
+++ b/qlever
@@ -502,24 +502,6 @@ function action_docker_off_DEPRECATED {
 # 
 # Skip this when calling "qlever update" because it's not only not necessary
 # then, but even annoying.
-if [ ${BASH_SOURCE[0]} == $0 ] \
-  && ( ( [ -z "${QLEVER_COMPLETIONS}" ] && [ "${BASH_COMPLETION}" != "0" ] ) || \
-     ( [ ! -e Qleverfile ] && ${QLEVERFILE_NEEDED} ) ); then
-    cat << EOT
-
-Bash completion not activated or no Qleverfile exists or both. Please run the
-qlever configuration once as follows (an existing Qleverfile will not be
-overwritten, don't worry): 
-
-${BLUE}. ${QLEVER_CMD}${NORMAL}
-
-Afterwards you can just call "qlever" (without the dot and without specifying
-the path). If you don't care about bash autocompletion or it doesn't work on
-your system, set BASH_COMPLETION = 0 in your Qleverfile.
-
-EOT
-    exit
-fi
 

@hannahbast
Copy link
Member

There is a new version of the qlever script, which will (eventually) solve this and many other issues. See #17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants