std::format does not play well with macos

[anonrig]

Referencing https://github.com/nodejs/node/actions/runs/12600455701/job/35119524310?pr=56452, std::format in URLPattern branch does not play well with macOS. cc @lemire

[lemire]

We have at least one macOS CI runner in ada:

https://github.com/ada-url/ada/actions/runs/12602577753/job/35125940436?pr=785

[lemire]

It builds fine in our other macos Runner:
https://github.com/ada-url/ada/actions/runs/12603258277/job/35127958267

[anonrig]

I think the minimum deployment target of Node.js makes it really hard to support std::format

[lemire]

@anonrig What is the Apple/LLVM version?

We can drop the std::format thing, it is not at all essential... but std::format is C++20 and supported in LLVM as of LLVM 14.

[anonrig]

node.js supports llvm 12 or higher. https://github.com/nodejs/node/blob/main/BUILDING.md

[lemire]

That C++20 support is described here:

https://clang.llvm.org/cxx_status.html#cxx20

[lemire]

But yeah, LLVM/libc++ 12 probably does not support std::format. :-/

[anonrig]

What do you think about checking for llvm version before using std::format?

[lemire]

@anonrig

The clean way is to check __cpp_lib_format.

https://en.cppreference.com/w/cpp/feature_test

[lemire]

See e297f7c