-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neopixel not working on CM4 #412
Comments
nope we just call it directly - wheres the PR that it was fixed in ws28? |
Oh I didn't create a PR I just hacked around locally. Created one now if you want to try it: jgarff/rpi_ws281x#445 |
maybe not installed right? dunno what to say, we've been using ws28 for years now :/ |
It was working fine when using their own Python examples. I think its just a namespace issue somewhere. I'll investigate further. |
I realize this issue should have probably went into the neopixel module? I can't see how the module https://github.com/adafruit/Adafruit_CircuitPython_NeoPixel could have worked otherwise if rpi-ws281x-python didn't provide such a shim to have the same API as the CPY neopixel driver. I can't see any sort of wrapping going on otherwise. So this is likely a breaking change coming from the underlying python module. I guess the dependency just hadn't been updated in a long while and it installed the older working version by default? @makermelissa @tannewt whats your position on that? |
I also just realized that the python module is dependant on @pimoroni fork and not the original repo by jgarff. |
This is largely due to me being in continued lockdown chaos and lacking the space for a proper Pi setup to vet and merge pulls for CM4 HWIDs. Will look into it ASAP. (also I don't have a CM4!) |
thanks! Lemme know if I can help. |
The API - ie: the removal of "NeoPixel" - was changed at the request of @ladyada (rpi-ws281x/rpi-ws281x-python#8) so that the ws281x library didn't trample on their Blinka Python library. Mentioned here - rpi-ws281x/rpi-ws281x-python#10 I don't know quite if/how this relates to your issue, but I venture that might not be something I can fix. As for the hardware IDs, I've merged them upstream and prepped the library for release... I can't build my usual (albeit not terribly comprehensive) glut of .whl files but I think Piwheels.org renders that step obsolete. A (test) source dist is available here- https://test.pypi.org/project/rpi-ws281x/4.2.6/ P.S. https://github.com/rpi-ws281x/rpi-ws281x-python/ is the source for the Python wrapper. I steered upstream |
Huh ok, now I'm official confused how everything is supposed to go together 😄 Thanks a lot for merging the hwids though. Looking forward to the next rpi-ws281x-python release. |
After the whole dependency chain got update it is now all working! |
Excellent! |
It complains about the hardware revision not being supported.
I tried fixing it in the underlying C lib (https://github.com/jgarff/rpi_ws281x) but when using the latest git version of that and patching it the Blinka library stops working entirely saying that the NeoPixel object doesn't exist. Was there maybe an API change?
It doesn't seem like anything but having the hardware ID in the detection code would prevent it from working.
The text was updated successfully, but these errors were encountered: