Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No implementation for sendRAW #59

Open
idankri opened this issue Jan 3, 2021 · 1 comment
Open

No implementation for sendRAW #59

idankri opened this issue Jan 3, 2021 · 1 comment

Comments

@idankri
Copy link

idankri commented Jan 3, 2021

Hi!
I noticed there is no implemented support for sending raw IR data.
The relevant function is written in IRLib_HashRaw.h, which had no include statement in IRLibCPE.h, and in addition the only linkage was broken:
The next line is a line is in IRLib_HashRaw.h:
#define IR_SEND_RAW case 0: IRsendRaw::send((uint16_t*)data,data2,khz); break;

The IR_SEND_RAW macro is used in IRLibCombo.h in IRsend class, in the send method, in order to send raw transmission. That will always result as an illegal cast between uint32_t to uint16_t* .
As a result it's impossible to use this method from the built-in IRsend object in the main object of CircuitPlayground.
I submitted PR of how I think this should be implemented.
Hope that helps :)
Idan

@ladyada
Copy link
Member

ladyada commented Jan 3, 2021

thanks! it may be a bit till we get to this PR as we have a lot of pending bug fixes to check - your PR is appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants