Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Padding calculation wrong when starting position % 4 != 0 #873

Open
5andr0 opened this issue Sep 25, 2024 · 1 comment · May be fixed by #878
Open

Padding calculation wrong when starting position % 4 != 0 #873

5andr0 opened this issue Sep 25, 2024 · 1 comment · May be fixed by #878
Labels
bug up for grabs

Comments

@5andr0
Copy link

5andr0 commented Sep 25, 2024 

private void SkipPadding()
    {
        var bytes = (int)(BaseStream.Position % 4);

I have a BaseStream where the xz file doesn't start at position 0. If this position is not dividable by 4, then the padding calculation is wrong.
Please fix this by calculating the position from the starting position.
Thanks
@adamhathcock
Copy link
Owner

PRs are welcome

@Morilli Morilli linked a pull request Oct 29, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug up for grabs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix XZBlock padding calculation when its stream's starting position % 4 != 0 Morilli/sharpcompress
2 participants
@5andr0 @adamhathcock