Skip to content
This repository has been archived by the owner on Feb 26, 2018. It is now read-only.

Support for Bootstrap 4 #71

Open
simplenotezy opened this issue Sep 9, 2015 · 8 comments
Open

Support for Bootstrap 4 #71

simplenotezy opened this issue Sep 9, 2015 · 8 comments

Comments

@simplenotezy
Copy link

No description provided.

@simplenotezy
Copy link
Author

I have started here: #72

@adamwathan
Copy link
Owner

Cool! I think we should probably make the Bootstrap 4 version a separate package so we don't break support for v3 though.

Currently even the switch to fieldset makes no difference, as the fieldset has no styles anyways, so a div looks the same. Let's wait until Bootstrap 4 is closer to release so we know what the final changes to the form markup will be and then fork this for a Bootstrap 4 version.

@simplenotezy
Copy link
Author

The fieldset change defiantly makes a difference. Just tested it here. <div class="form-group"> breaks everything, whereas <fieldset class="form-group"> solves it.

Agreed on new package; can you create such, and we can start working already?

@adamwathan
Copy link
Owner

This is a screenshot from the Bootstrap 4 docs, I changed some of these to divs and left some as fieldsets. Can you tell which ones are divs?

image

These are the styles applied by the fieldset:

image

div elements get those same styles by default.

Is it maybe only in the horizontal or inline layouts or something that things change?

@simplenotezy
Copy link
Author

Yes I experienced this on horizontal form.

@jeff-h
Copy link

jeff-h commented Mar 15, 2017

Bootstrap 4 is considerably further along now — would you consider creating the separate package so development can start on bootforms for Bootstrap 4?

@adamwathan
Copy link
Owner

Hey @jeff-h, I'm not actually using this package myself anymore and don't have any intention of adopting Bootstrap 4 on my own projects, but I'd happily support anyone who would like to fork this package to create a dedicated Bootstrap 4 version.

@vpratfr
Copy link

vpratfr commented Nov 15, 2017

Hi all,

I have been looking for an alternative (both BS 3 and BS 4) but so far I did not get much success.

The best I found was Spatie's package to produce HTML with some nifty functions.

So I have extended their package and will hopefully get to a 1.0 some time soon as I need this on a client project.

I would appreciate any contribution there to help make a decent alternative to this package that Adam has been kind enough to offer for so many years.

Here is the project for Bootstrap 4 helpers (currently about 70% done for forms, no version tagged yet) and a companion for Font Awesome (stable 1.0.3)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants