Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

For the max_value and min_value parameters of the max_min_values () function in file audio_file_analysis.py #2

Open
Jin-Tao-208 opened this issue Aug 3, 2021 · 1 comment

Comments

@Jin-Tao-208
Copy link

Hi Andrew,
In the max_min_values () function of theaudio_file_analysis.py file, you set the values max_value = 0 and min_value = 1e20, respectively.This puzzles me because it seems to be the opposite of the literal meaning of maximum and minimum. Hope to answer.
Looking forward to your reply.
Thank you very much.

Best
Stella

@adbailey1
Copy link
Owner

Hi Stella,

So in that function we are trying to work out what size the max and min files are. To do this, I set two variables max_value and min_value. Max_value is set to 0 because we don't know what the maximum file length is but every file is longer than 0 so max_value will be updated correctly. The same idea is true for min_value, I have set the initial value to much greater than the length of any file in the dataset so that it will update correctly.

Hope this makes sense.

Kind regards,

Andrew

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants