Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extended Chebyshev shape #292

Open
myurkin opened this issue Apr 23, 2021 · 1 comment
Open

Extended Chebyshev shape #292

myurkin opened this issue Apr 23, 2021 · 1 comment
Labels
comp-Logic Related to internal code logic good first issue Should be easy to solve for someone not familiar with the internals of the code pri-Low Kept mostly for reference usability Makes using code more convenient

Comments

@myurkin
Copy link
Member

myurkin commented Apr 23, 2021 •
edited
Loading

Currently ADDA supports axisymmetric (2D) Chebyshev particle, given by equation r=r0(1+εcos(nθ)). It should be straightforward to extend it to non-axisymmetric (3D) ones, given by equation r=r0(1+εcos(nθ)cos(mφ)). Moreover, the existing shape option -shape chebyshev can be used for that (with full backward compatibility) by adding a third optional argument m.

For a reference - https://github.com/adda-team/adda/wiki/AddingShape

This idea appeared in discussion with Michael Kahnert (@michaelkahnert). He is experienced in simulating such shapes with his T-matrix code accounting for finite-order particle symmetries - Tsym.
@myurkin myurkin added feature Allows new functionality help wanted Should be doable without understanding the whole code, but not as easy as "good first issue" comp-Logic Related to internal code logic pri-Low Kept mostly for reference labels Apr 23, 2021
@myurkin
Copy link
Member Author

myurkin commented Apr 23, 2021

/cc @stefaniagl

@myurkin myurkin added good first issue Should be easy to solve for someone not familiar with the internals of the code usability Makes using code more convenient and removed help wanted Should be doable without understanding the whole code, but not as easy as "good first issue" feature Allows new functionality labels Apr 23, 2021
@myurkin myurkin mentioned this issue Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
comp-Logic Related to internal code logic good first issue Should be easy to solve for someone not familiar with the internals of the code pri-Low Kept mostly for reference usability Makes using code more convenient
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@myurkin