Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors: remove deprecated isBright and isDark functions #5031

Closed
mrtnzlml opened this issue Sep 14, 2022 · 1 comment
Closed

Colors: remove deprecated isBright and isDark functions #5031

mrtnzlml opened this issue Sep 14, 2022 · 1 comment

Comments

@mrtnzlml
Copy link
Member

mrtnzlml commented Sep 14, 2022

The goal of this task is to remove deprecated functions located in src/css-colors/src/isBright.js and src/css-colors/src/isDark.js, respectively. This should include removing of all related files and updating the README file and CHANGELOG (all located under src/css-colors/).

Related issue: #2908

Acceptance criteria

  1. The isBright and isDark functions and all related files were removed and cleaned up.
  2. README and CHANGELOG located in src/css-colors/ are updated to reflect the new reality.
  3. The PR follows the project conventions.
  4. All CI checks pass, and all code review comments are addressed.

How to install and run this project

git clone --depth=100 [email protected]:adeira/universe.git
cd universe
corepack enable

chmod +x ./x
./x install

To run JavaScript tests:

./x tests

For more information, please visit README.md located at the root of this project. If you get lost, you can also start a new discussion. 😎

@mrtnzlml
Copy link
Member Author

mrtnzlml commented Oct 2, 2022

Successfully completed in #5106, thanks @jaebirds!

@mrtnzlml mrtnzlml closed this as completed Oct 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant