-
Notifications
You must be signed in to change notification settings - Fork 0
/
TODO
29 lines (20 loc) · 2.08 KB
/
TODO
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
* There are a couple of untested lines of code in the Oauth2Test used by Valportaal. We probably need to write an acceptance test for it.
Try to write a test that looks like the DigiD expected flow.
* We will need to create a sitemap file for each installation, and try to submit it to the search engines (Yandex, Bing, Google).
see https://ahrefs.com/blog/how-to-create-a-sitemap/
* Since search will only work after the site is indexed (which might take a while after installation), it would be nice to be able to only show the search box when it is working. This could be done automatically by doing an empty query (site: valportaal.thishospital.nl) and counting the number of results returned. I think this could be done using:
https://serpapi.com/duckduckgo-search-api
and counting the length of organic_results in the returned JSON.
* testing of the static/ served javascript files
* Add a test for the zoom buttons. Checking for .exists in TestCafe does not seem to work.
* Zoom function is a bit clunky; combines poorly with ctrl++ zoom. Consider improving it.
* The .env files still have the most-recent commit message "adfice-ace is responsible for specifying the portal db". This is not true: the portal is a separate application and specifies its own db. Check that this is consistent throughout the repo.
If we decide to use personalized portal:
* replace current test patient data with new data (to match updates in CDSS) -- check if this is now done?
* move patient_id from URL parameter to session_id in a cookie?
* See what is required/recommended for DigiD (only the page accessed via DigiD uses an ID)
* url-hacking/cookie-hacking shouldn't work
* patient_id should remain an internal identifier only and should not have any external meaning
* need a mapping of session_id to patient_id
* make a "build valportaal vm" script
* Consider adjusting advice.html to have browser detection. Currently the page does not work with IE11; should give a warning instead of having a non-functioning page. It should work with Firefox, Chromium, and Edge since these are the browsers that support DigiD.