You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed running unit tests in our application that ssml nodes were getting a 'default' prefix after being embedded in a parent element. This occurred under Ruby 1.9.3-p484 but not under JRuby 1.7.4.
I wonder, but do not know, if this conditional treatment of Nokogiri implementation of JRuby contributes to this phenomenon. While this is not a huge issue for us since we're running JRuby in production, it caused some concern that the tests behave differently under different rubies. I am also concerned for anybody out there using MRI.
Thanks!
The text was updated successfully, but these errors were encountered:
So, this example has dependencies on your application and test suite and so cannot be reproduced easily. Please provide an example (or even a PR for a test on this project) demonstrating the issue.
At the same time, the prefix is compliant with the XML specification, and any XML compliant parser / TTS engine will have no trouble with such a document. As such, I'm going to mark this awaiting-contribution.
I noticed running unit tests in our application that ssml nodes were getting a 'default' prefix after being embedded in a parent element. This occurred under Ruby 1.9.3-p484 but not under JRuby 1.7.4.
Sample test:
Sample test output running 1.9.3-p484:
JRuby passes happily.
I wonder, but do not know, if this conditional treatment of Nokogiri implementation of JRuby contributes to this phenomenon. While this is not a huge issue for us since we're running JRuby in production, it caused some concern that the tests behave differently under different rubies. I am also concerned for anybody out there using MRI.
Thanks!
The text was updated successfully, but these errors were encountered: