Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIN change confirmation message is played back before the PIN change happens #19

Open
CodeMangler opened this issue Jan 10, 2014 · 1 comment
Open

PIN change confirmation message is played back before the PIN change happens #19

CodeMangler opened this issue Jan 10, 2014 · 1 comment

Comments

@CodeMangler
Copy link
Contributor

MailboxSetPinController plays back the change PIN confirmation message before calling store.change_pin_for_mailbox.
This is misleading for cases when change_pin_for_mailbox fails, since we would have played back a message saying the PIN has been changed, but the PIN hasn't actually been changed.

See: https://github.com/adhearsion/voicemail/blob/develop/lib/voicemail/call_controllers/mailbox_set_pin_controller.rb#L39
@benlangfeld
Copy link
Member

Would you be prepared to submit a PR for this, @CodeMangler?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@CodeMangler @benlangfeld