Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing the fix to the reorg race condition crash #13

Open
defuse opened this issue Feb 13, 2023 · 1 comment
Open

Missing the fix to the reorg race condition crash #13

defuse opened this issue Feb 13, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@defuse
Copy link

defuse commented Feb 13, 2023 •
edited
Loading

In passing, I noticed that this fork of lightwalletd is missing this bug fix, without which the server can crash when a reorg occurs at just the right time: zcash#409.

The patch in ECC's repo will need ZcashFoundation/zebra#6134 to merge in order to work with zebra.

(I'd recommend rebasing on top of ECC's upstream repo, it will make code reviews quicker!)
@defuse defuse added the bug Something isn't working label Feb 13, 2023
@teor2345
Copy link

I'll make sure that Zebra PR gets in our 1.0.0-rc.5 release.

@teor2345 teor2345 mentioned this issue Feb 14, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@defuse @teor2345