-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] favicon's links not match the full baseURL #1366
Comments
@adityatelange I mean if I set the baseURL to be http://a.com/base, the following part of html pages generated by paperMod: <link rel="icon" href="http://a.com/assets/favicon.ico">
<link rel="icon" type="image/png" sizes="16x16" href="http://a.com/assets/favicon.ico">
<link rel="icon" type="image/png" sizes="32x32" href="http://a.com/assets/favicon.ico"> should be: <link rel="icon" href="http://a.com/base/assets/favicon.ico">
<link rel="icon" type="image/png" sizes="16x16" href="http://a.com/base/assets/favicon.ico">
<link rel="icon" type="image/png" sizes="32x32" href="http://a.com/base/assets/favicon.ico"> Cause sometimes, there are multi-sub-sites under the same domian in sub directories. root-
-siteA
-siteB |
Maybe this wording is what confused the other user, but I get what you mean. The favicon URL should be relative to or based on I encountered this as well with Git Lab Pages because the base URL is of the form |
I just had this same issue deploying on github pages, I don't think it's a bug though.
The starting slash makes the difference! If you do put the starting slash then what you get is: http://a.com/assets/favicon.ico with the base part of the URL removed. Hope it helps! |
Indeed it does, thanks for this tip! I've removed the first slash and fixed my config. |
Describe the bug
favicon's links not match the full baseURL
Steps to reproduce the behavior:
build with baseURL param.
index.html:
Expected behavior:
favicon's link should match the baseURL
The text was updated successfully, but these errors were encountered: