Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] (Deeplink)Android URL Scheme Definition Not Very Well #266

Open
CodeMasterYi opened this issue Feb 9, 2023 · 4 comments
Open

Comments

@CodeMasterYi
Copy link

In AdjustEditorPreprocessor.cs there is an method AddURISchemes,

  1. We find you add android:host attribute to the scheme data node, while README.md says you should write them with :// part at the end(no host)
  2. according to Android Document About Deeplink
    screenshot
    including two scheme data node in one intent filter is not very nice
    for instance:
    in one intent filter, there is an https scheme with host a.example.com and an my_app scheme with host b.example.com.
    we can use https://b.example.com and my_app://a.example.com(They are not expected.)
@CodeMasterYi
Copy link
Author

image

@CodeMasterYi CodeMasterYi changed the title [Question] (Deeplink)Android URL Scheme Definition [Question] (Deeplink)Android URL Scheme Definition Not Very Well Feb 9, 2023
@CodeMasterYi
Copy link
Author

CodeMasterYi commented Feb 9, 2023

My modification in AdjustEditorPreprocessor.cs(Left is yours, right is mine):
image
image

@CodeMasterYi
Copy link
Author

See PR #267

@CodeMasterYi
Copy link
Author

Any reply?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant