Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mixcloud refactored to React over Angular #36

Open
adlawson opened this issue Aug 21, 2017 · 2 comments
Open

Mixcloud refactored to React over Angular #36

adlawson opened this issue Aug 21, 2017 · 2 comments

Comments

@adlawson
Copy link
Owner

All selectors used by this extension rely on the Angular DOM, but Mixcloud have now migrated to a React frontend. No tracklist is currently rendered.

@mactkg
Copy link
Collaborator

mactkg commented Aug 22, 2017

Screenshot from Gyazo

I found raw tracklist data using React Dev Tool. Can we capture the state in our script...?

@adlawson
Copy link
Owner Author

Thanks for taking a look into it @mactkg!
I think for this fix, I'll attempt to simply change the selectors to bung in the tracklist like we did before.

Maybe after that's done I can investigate rewriting this extension in react to take advantage of the existing data. I'd still want to keep the extension download size small, so it's still a maybe.

Repository owner deleted a comment from filipeteles Sep 20, 2017
Repository owner deleted a comment from christoskokock Sep 20, 2017
Repository owner locked and limited conversation to collaborators Sep 20, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants