Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one sentence per line #449

Open
zrgt opened this issue Jul 9, 2024 · 4 comments
Open

Use one sentence per line #449

zrgt opened this issue Jul 9, 2024 · 4 comments
Labels
accepted accepted in principle to be fixed documentation Improvements or additions to documentation enhancement New feature or request

Comments

@zrgt
Copy link
Collaborator

zrgt commented Jul 9, 2024

Currently we have in our documentation multiple sentences in one line, like:
The only thing that cannot be defined in the template itself is the unique ID of the submodel instance itself (it is not identical to the ID of the submodel template), as well as the property values, etc. Templates also define cardinalities, for example whether an element is optional or not. Submodel element lists typically contain more than one element: the template contains an exemplary element template; the other elements can be created by copy/paste from this template.

There is a recommendation from AsciiDoc community to handle the text as a source code and to use one sentence per line.

They list the following advantages by using this technique:

- It prevents reflows (meaning a change early in the paragraph won’t cause the remaining lines in the paragraph to reposition).
- You can easily swap sentences.
- You can easily separate or join paragraphs.
- You can comment out sentences or add commentary to them.
- You can spot sentences which are too long or sentences that vary widely in length.
- You can spot redundant (and thus mundane) patterns in your writing.
  • Additionally we will get much more clear git diffs

Proposal: Convert current documents to the one sentence per line-format and enforce this standard in all future documents

@zrgt zrgt added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 9, 2024
@mristin
Copy link
Collaborator

mristin commented Jul 9, 2024

I strongly second this approach.

@g1zzm0
Copy link
Collaborator

g1zzm0 commented Jul 9, 2024

me three

@BirgitBoss
Copy link
Collaborator

  • This needs to be documented in "how to maintain specification" or similar.
  • It is not clear to me whether there is tooling available to change the files correspondingly? Or would this be manual work?
  • You would like to add a github action for asciidoc validation before accepting a PR?

@BirgitBoss
Copy link
Collaborator

Decision 2024-07-19: approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted accepted in principle to be fixed documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants