Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat]: Add a max-height css property for sp-action-menu / sp-menu #4785

Open
1 task done
pwong09 opened this issue Sep 25, 2024 · 1 comment
Open
1 task done

[Feat]: Add a max-height css property for sp-action-menu / sp-menu #4785

pwong09 opened this issue Sep 25, 2024 · 1 comment
Labels
Component: Action Menu Discuss w/ design Needs insight from Spectrum or another designer enhancement New feature or request needs jira ticket triage An issue needing triage

Comments

@pwong09
Copy link

pwong09 commented Sep 25, 2024

Code of conduct

  • I agree to follow this project's code of conduct.

Impacted component(s)

sp-popover

Description of the requested feature

When using the sp-action-menu, there is no accessible way via css property to limit the height of the sp-menu.
We would like to add a max-height option in cases where we know a user could potentially have hundreds of options to select from. In this scenario, the menu fills the entire height of the available screen which can block/temporarily hide other important, informative and interactive UI.

Mockups or screenshots

Screenshot 2024-09-23 at 3 47 28 PM

Implementation notes or ideas

We have already investigated the sp-combobox component and it is not an applicable solution for us at this time. The design implementation is an icon that a user clicks on to open the menu. Then the menu opens with an option to either create a library or save to an existing library. Users could have many libraries which are dynamically fetched and rendered when a user scrolls to the end of the menu.

@pwong09 pwong09 added enhancement New feature or request needs jira ticket triage An issue needing triage labels Sep 25, 2024
@rubencarvalho
Copy link
Collaborator

Design team will discuss this issue (SDS-13984).

@najikahalsema najikahalsema added Discuss w/ design Needs insight from Spectrum or another designer Component: Action Menu labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Action Menu Discuss w/ design Needs insight from Spectrum or another designer enhancement New feature or request needs jira ticket triage An issue needing triage
Projects
None yet
Development

No branches or pull requests

3 participants