You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Since <sp-dialog> with the error attribute will be removed in the future, we should support the transition from <sp-dialog> to <sp-alert-dialog> in the cases that <sp-dialog-wrapper> should render the error variant of the <sp-dialog>.
Right now, if we have <sp-dialog-wrapper error></sp-dialog-wrapper> and leverage its other properties, we are not as easily able to transition to using an <sp-alert-dialog variant="error"></sp-alert-dialog>.
Code of conduct
Impacted component(s)
sp-dialog-wrapper
Description of the requested feature
Since
<sp-dialog>
with theerror
attribute will be removed in the future, we should support the transition from<sp-dialog>
to<sp-alert-dialog>
in the cases that<sp-dialog-wrapper>
should render theerror
variant of the<sp-dialog>
.Right now, if we have
<sp-dialog-wrapper error></sp-dialog-wrapper>
and leverage its other properties, we are not as easily able to transition to using an<sp-alert-dialog variant="error"></sp-alert-dialog>
.Mockups or screenshots
No response
Implementation notes or ideas
Draft PR with example: https://github.com/adobe/spectrum-web-components/pull/4909/files
The text was updated successfully, but these errors were encountered: