diff --git a/packages/popover/src/Popover.ts b/packages/popover/src/Popover.ts
index 2e34c2c12a..8a934f4b50 100644
--- a/packages/popover/src/Popover.ts
+++ b/packages/popover/src/Popover.ts
@@ -14,7 +14,6 @@ import {
CSSResultArray,
html,
nothing,
- PropertyValues,
SpectrumElement,
TemplateResult,
} from '@spectrum-web-components/base';
@@ -35,13 +34,6 @@ export class Popover extends SpectrumElement {
return [popoverStyles];
}
- /**
- * Whether the popover should manage the application
- * of padding to its content or not.
- */
- @property({ type: Boolean, reflect: true })
- public dialog = false;
-
/**
* Whether the popover is visible or not.
*/
@@ -74,23 +66,6 @@ export class Popover extends SpectrumElement {
`;
}
- protected override update(changes: PropertyValues): void {
- if (window.__swc.DEBUG) {
- if (changes.has('dialog') && this.dialog) {
- window.__swc.warn(
- this,
- `<${this.localName}> no longer supports the "dialog" attribute. Please slot an element into the <${this.localName}> instead.`,
- 'https://opensource.adobe.com/spectrum-web-components/components/popover/#dialog-popovers',
- {
- type: 'api',
- level: 'deprecation',
- }
- );
- }
- }
- super.update(changes);
- }
-
protected override render(): TemplateResult {
return html`
diff --git a/packages/popover/src/spectrum-config.js b/packages/popover/src/spectrum-config.js
index 32f325e0f6..c18099ff30 100644
--- a/packages/popover/src/spectrum-config.js
+++ b/packages/popover/src/spectrum-config.js
@@ -27,10 +27,6 @@ const config = {
converter.classToHost(),
converter.classToAttribute('is-open', 'open'),
converter.classToAttribute('spectrum-Popover--withTip', 'tip'),
- converter.classToAttribute(
- 'spectrum-Popover--dialog',
- 'dialog'
- ),
...converter.enumerateAttributes(
[
['spectrum-Popover--top', 'top'],
diff --git a/packages/popover/stories/popover.stories.ts b/packages/popover/stories/popover.stories.ts
index 7e5c081aa9..75b7b04834 100644
--- a/packages/popover/stories/popover.stories.ts
+++ b/packages/popover/stories/popover.stories.ts
@@ -97,7 +97,6 @@ const Template = ({ tip, placement, open }: StoryArgs): TemplateResult => {
style="color: var(--spectrum-gray-800); position: relative; display: contents"
>
-
Popover Title
-
+
+
+
Popover title
Cupcake ipsum dolor sit amet jelly beans. Chocolate jelly caramels.
Icing soufflé chupa chups donut cheesecake. Jelly-o chocolate cake
sweet roll cake danish candy biscuit halvah
-
+
`);
diff --git a/packages/popover/test/popover.test.ts b/packages/popover/test/popover.test.ts
index cae6611511..b232f7a05a 100644
--- a/packages/popover/test/popover.test.ts
+++ b/packages/popover/test/popover.test.ts
@@ -10,6 +10,7 @@ OF ANY KIND, either express or implied. See the License for the specific languag
governing permissions and limitations under the License.
*/
import '@spectrum-web-components/popover/sp-popover.js';
+import '@spectrum-web-components/dialog/sp-dialog.js';
import { Popover } from '@spectrum-web-components/popover';
import { elementUpdated, expect, fixture, html } from '@open-wc/testing';
@@ -17,19 +18,17 @@ describe('popover', () => {
let popover!: Popover;
beforeEach(async () => {
- popover = await fixture(
- html`
-
-