Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove thumbnail deprecated sizes #4760

Draft
wants to merge 1 commit into
base: ruben/remove-deprecations
Choose a base branch
from

Conversation

rubencarvalho
Copy link
Collaborator

Description

Removed the sp-thumbnail deprecated sizes, along with all associated references and dependencies.

Related issue(s)

Motivation and context

For the upcoming 1.0.0 release of Spectrum Web Components, we will remove the deprecated components and features.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@rubencarvalho rubencarvalho marked this pull request as ready for review September 16, 2024 23:04
@rubencarvalho rubencarvalho requested a review from a team as a code owner September 16, 2024 23:04
Copy link

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

Copy link

Tachometer results

Chrome

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 774 kB 23.17ms - 23.44ms - faster ✔
3% - 7%
0.72ms - 1.62ms
branch 751 kB 24.04ms - 24.90ms slower ❌
3% - 7%
0.72ms - 1.62ms
-
Firefox

thumbnail permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 774 kB 55.93ms - 60.67ms - unsure 🔍
-6% - +4%
-3.41ms - +2.49ms
branch 751 kB 57.01ms - 60.51ms unsure 🔍
-4% - +6%
-2.49ms - +3.41ms
-

@rubencarvalho rubencarvalho marked this pull request as draft September 24, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant