fix(breadcrumbs): trigger change event on breadcrumbs via keyboard #4769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Pull Request Test Coverage Report for Build 11017229033Details
💛 - Coveralls |
Tachometer resultsChromebreadcrumbs permalinkbasic-test
Firefoxbreadcrumbs permalinkbasic-test
|
Rajdeepc
previously approved these changes
Sep 24, 2024
|
Would it work to handle the keydown event and trigger the same action as the click event when the pseudo-code: <breadcrumb-item @keydown=${this.handleKeyDown}>
protected handleKeyDown(event: KeyboardEvent): void {
if (event.key === 'Enter' || event.keyCode === 13) {
this.handleClick(event);
}
} |
| @@ -86,7 +86,9 @@ export class BreadcrumbItem extends LikeAnchor(Focusable) { | |||
| return html` | |||
| <a | |||
| id="item-link" | |||
| href=${ifDefined(!this.isLastOfType ? this.href : undefined)} | |||
| href=${ifDefined( | |||
| !this.isLastOfType ? this.href || '#' : undefined | |||
There was a problem hiding this comment.
Could this lead to a jump to the top of the page when "#" is set?
There was a problem hiding this comment.
Good catch! I have updated the changes. Let' see if we can land this for tomorrow's release.
blunteshwar
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to
undefinedhref attribute, breadcrumb items without hrefs would not trigger change events on keyboard Enter press.I added a similar fix which is used for
sp-sidenav-item, which is a placeholder href value.Related issue(s)
Fix for #4733
Motivation and context
How has this been tested?
Test case 1
Did it pass in Desktop?
Did it pass in Mobile? - N/A
Did it pass in iPad? - N/A
Screenshots (if appropriate)
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.