diff --git a/packages/coachmark/coach-indicator.md b/packages/coachmark/coach-indicator.md index dec22c0b71..7de21c9980 100644 --- a/packages/coachmark/coach-indicator.md +++ b/packages/coachmark/coach-indicator.md @@ -23,16 +23,16 @@ When looking to leverage the `CoachIndicator` base class as a type and/or for ex import { CoachIndicator } from '@spectrum-web-components/coachmark'; ``` -## Variants +## Static variants - + Standard ```html - - + + ``` @@ -41,8 +41,8 @@ import { CoachIndicator } from '@spectrum-web-components/coachmark'; ```html - - + + ``` diff --git a/packages/coachmark/src/CoachIndicator.ts b/packages/coachmark/src/CoachIndicator.ts index a96a4735fd..5833041373 100644 --- a/packages/coachmark/src/CoachIndicator.ts +++ b/packages/coachmark/src/CoachIndicator.ts @@ -12,7 +12,6 @@ governing permissions and limitations under the License. import { CSSResultArray, html, - PropertyValues, SpectrumElement, TemplateResult, } from '@spectrum-web-components/base'; @@ -33,9 +32,6 @@ export class CoachIndicator extends SpectrumElement { @property({ reflect: true }) public static?: 'white' | 'black'; - @property({ reflect: true }) - public variant?: 'white' | 'black'; - protected override render(): TemplateResult { return html`
@@ -43,22 +39,4 @@ export class CoachIndicator extends SpectrumElement {
`; } - - protected override updated(changes: PropertyValues): void { - super.updated(changes); - if ( - changes.has('variant') && - (this.variant || typeof changes.get('variant')) - ) { - this.static = this.variant; - if (window.__swc.DEBUG) { - window.__swc.warn( - this, - `The "variant" attribute/property of <${this.localName}> have been deprecated. Use "static" with any of the same values instead. "variant" will be removed in a future release.`, - 'https://opensource.adobe.com/spectrum-web-components/components/badge/#fixed', - { level: 'deprecation' } - ); - } - } - } } diff --git a/packages/coachmark/stories/coach-indicator-static.stories.ts b/packages/coachmark/stories/coach-indicator-static.stories.ts index e1432c0921..781089b7a8 100644 --- a/packages/coachmark/stories/coach-indicator-static.stories.ts +++ b/packages/coachmark/stories/coach-indicator-static.stories.ts @@ -22,14 +22,14 @@ export default { export const staticWhite = (): TemplateResult => { return html` - - + + `; }; export const staticBlack = (): TemplateResult => { return html` - - + + `; }; diff --git a/packages/coachmark/test/coach-indicator.test.ts b/packages/coachmark/test/coach-indicator.test.ts index a0030a5888..dc2facfa19 100644 --- a/packages/coachmark/test/coach-indicator.test.ts +++ b/packages/coachmark/test/coach-indicator.test.ts @@ -18,28 +18,15 @@ import { testForLitDevWarnings } from '../../../test/testing-helpers.js'; describe('CoachIndicator', () => { testForLitDevWarnings( async () => - await fixture( - html` - - ` - ) + await fixture(html` + + `) ); it('loads default coach-indicator accessibly', async () => { - const el = await fixture( - html` - - ` - ); + const el = await fixture(html` + + `); await elementUpdated(el); await expect(el).to.be.accessible(); }); - it('loads coach-indicator white static variant', async () => { - const el = await fixture( - html` - - ` - ); - await elementUpdated(el); - expect(el.static == 'white').to.be.true; - }); });