Replies: 1 comment 2 replies
-
Hey @vhargrave! What are the guidelines from Consonant, should we have support for the purplish buttons? |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey all (especially the gnav team @salonijain3 & @bandana147)
I'm working on the migration of Express to Milo, and one of the requirements from our design team is that we can steer certain styles in the gnav & footer, so that the links & buttons have that nice purplish Express look - See example here
For me to achieve this for now, I'm overriding some of the css variables & classes from milo - https://github.com/adobecom/express-milo/blob/gnav/express/styles/styles.css#L1109-L1127, but as a long term solution I feel a bit uncomfortable since these classes or variables could change.
As a longer term solution we could allow these colors to be overriden over the metadata , but I also think we're the only consumer with this requirement at the moment.
Or alternatively we could just add a comment for these variables and things we're overriding in milo, so that it's clear if they're renamed that the Express project will be affected. Curious on your thoughts and input, thanks!
Beta Was this translation helpful? Give feedback.
All reactions