-
Notifications
You must be signed in to change notification settings - Fork 169
Submitting PRs
- Every PR needs at least two approvals.
- Approvals & changes can come from anyone. Milo Admins are responsible for the binding approvals.
- Milo Contributors can merge approved PRs into any branch besides main.
- Milo Admins can merge approved PRs into main.
A PR must pass all audits run by Github. If an audit does not pass, an admin is required to merge.
- For Lighthouse, we generally expect 98 or above.
- For code coverage, we generally expect 98% or above.
- For Adobe CLA, you must be a part of the adobecom org.
There are exceptions to every audit depending on the context of the fix or feature.
Place this in your home folder.
.gitcommittemplate
MWPW-xxxx - Summarize changes in 50 characters or less
* Add your
* Specicic
* Features or fixes
Resolves: [MWPW-NUMBER](MWPW-URL)
**Test URLs:**
- Before: https://main--milo--adobecom.hlx.page/?martech=off
- After: https://<branch>--milo--adobecom.hlx.page/?martech=off
We encourage you to have one commit per PR. By doing so, your PR will be pre-populated with relevant information. This is not required. If you wish to follow this process, it may require squashing commits before you PR. Please see below for our recommended way of squashing commits. Reach out to the team if you have more questions.
We recommend the following title format:
MWPW-xxxx - Summarize changes in 50 characters or less
This ensures glanceable information for the reviewers and will help get a PR approved faster.
We believe every commit that lands into Milo main should have meaning. We do not expect this for work in progress commits. This is why we recommend squashing your commits to
No new draft PR should be opened to keep the PR count down. If you would like a review of draft code please reach out on milo-community discussion forum with a link to your branch. Another way to tackle "draft" PRs is to send us a diff. For example: https://github.com/adobecom/milo/compare/main...review-schema
Opening a PR will automatically request the code owners for a review. Usually open PRs are actively being looked at by the community. If your PR is urgent such as a critical production bug or your PR does not have any kind of response for over 48 hours, you can reach out to #milo-dev (or #milo-community for access to that channel) on slack.