From 656b38cfa8c07cbdff25cadca422a960c071cbe0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Michal=20Bryx=C3=AD?= Date: Thu, 25 Apr 2024 16:01:42 +0200 Subject: [PATCH] chore: Bump node version used on GitHub - While [adding trivial change the the code](https://github.com/rwjblue/ember-cli-content-security-policy/pull/365) I bumped into CI being red from various reasons [last one](https://github.com/rwjblue/ember-cli-content-security-policy/actions/runs/8820844298/job/24215355798?pr=365) ended with a hard error on: ``` [3/5] Fetching packages... error ember-cli-babel@8.2.0: The engine "node" is incompatible with this module. Expected version "16.* || 18.* || >= 20". Got "12.22.12" error Found incompatible module. ``` - I tried to reproduce locally, but `node@12.x` is surprisingly not trivial to install on modern OSX without breaking my other projects. - I tried to consult the [node support](https://github.com/ember-cli/ember-cli/blob/master/docs/node-support.md) matrix for EmberJS and since `16.x` is supported through `3.28.0 - 5.3.0`, it seems like a safe bet. --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b362e9e..ca3cf13 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -7,7 +7,7 @@ on: pull_request: env: - NODE_VERSION: '12.x' + NODE_VERSION: '16.x' jobs: lint: