Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning in Ember 3.4 #223

Open
paxer opened this issue Oct 3, 2018 · 1 comment
Open

Deprecation warning in Ember 3.4 #223

paxer opened this issue Oct 3, 2018 · 1 comment

Comments

@paxer
Copy link

paxer commented Oct 3, 2018

Version of x-select: 3.1.1

Ember Version / Ember CLI Version:

Ember Version: 3.4
Ember CLI Version: 3.4.3

Expected Behavior

no deprecation warnings

Actual Behavior

After upgrade to Ember 3.4 I am getting deprecation warnings

DEPRECATION: You called <my-app@component:x-select::ember975>.sendAction("action") but Component#sendAction is deprecated. Please use closure actions instead. [deprecation id: ember-component.send-action] See https://emberjs.com/deprecations/v3.x#toc_ember-component-send-action for more details.

Steps To Reproduce:

I have deprecation warning for each component use. I use exactly the same method of invocation like described in ReadMe

{{#x-select value=selections multiple=true action="selectionsChanged" as |xs|}}

etc
@paxer paxer changed the title Deprecation warning when use in Ember 3.4 Deprecation warning in Ember 3.4 Oct 3, 2018
@triage-new-issues triage-new-issues bot removed the triage label Oct 3, 2018
@Robdel12
Copy link
Collaborator

Robdel12 commented Oct 3, 2018

Hey @paxer thanks for the issue. I'm currently plugging away at this deprecation in this branch: https://github.com/thefrontside/emberx-select/compare/rd/upgrade-ember

Lots of refactoring going on & since fixing this deprecation will create a breaking change, it'll be x-select 4.0. Don't worry though, that's basically the only breaking change that is going to happen (I think! knocks on wood)

GitHub
Select component for Ember based on the native html select element. - thefrontside/emberx-select

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants