Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add upstream maintainer info to support page #1984

Closed
wants to merge 2 commits into from
Closed

Conversation

sxa
Copy link
Member

@sxa sxa commented Jul 13, 2023

Description of change

Add upstream maintainer info for each major version to the support page

Checklist

  • npm test passes
  • documentation is changed or added (if applicable)
  • permission has been obtained to add new logo (if applicable)
  • contribution guidelines followed here

@netlify
Copy link

netlify bot commented Jul 13, 2023

Deploy Preview for eclipsefdn-adoptium ready!

Name Link
🔨 Latest commit 6092222
🔍 Latest deploy log https://app.netlify.com/sites/eclipsefdn-adoptium/deploys/64afcc47a4b7b300084ddb09
😎 Deploy Preview https://deploy-preview-1984--eclipsefdn-adoptium.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #1984 (6092222) into main (67f4d48) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1984   +/-   ##
=======================================
  Coverage   99.15%   99.15%           
=======================================
  Files          85       85           
  Lines        6181     6181           
  Branches      507      507           
=======================================
  Hits         6129     6129           
  Misses         52       52           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sxa
Copy link
Member Author

sxa commented Jul 13, 2023

Removed the lead maintainer's name as it was making the table a little too wide - this is what it looked like before that change:
image

I've also considered moving the maintainer to under the java version in the first column, which would be an alternative.
Direct link to current previous of this page

@sxa sxa self-assigned this Jul 13, 2023
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Andrew Haley would disagree that it is Red Hat, he's always stated that the project lead is an individual, not a company...

@tellison
Copy link
Contributor

@sxa what is the purpose of adding this information to the table? I don't think it is relevant in the context of Adoptium.

@sxa
Copy link
Member Author

sxa commented Jul 18, 2023

@sxa what is the purpose of adding this information to the table? I don't think it is relevant in the context of Adoptium.

Fair enough - my view was that it was useful (to myself to remember who maintained each if no-one else!) to know who was involved in each release and that it wasn't Oracle who maintained all of the LTS releases (which I don't think the general customer base necessarily realises).

If we believe it's not relevant or useful to our customers or our goals then I could cancel it. I thought we'd discussed this earlier in the year somewhere but I can't find a reference to it.

@tellison
Copy link
Contributor

@sxa: I propose this is cancelled, and if the information is not clear in the OpenJDK project then I suggest a change there to clarify who maintains the various code streams.

@sxa
Copy link
Member Author

sxa commented Jul 21, 2023

I don't think it's unclear upstream. This was more about raising the visibility of who is maintaining it on a single page that non developers were likely to visit but if you don't think it's appropriate here I'll close on the absence of their being comments expressing an appetite for it at present.

@sxa sxa closed this Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants