-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
404 Not Found for /v3/assets/version/21.0.2+13 #945
Comments
The version is https://api.adoptium.net/v3/assets/version/21.0.2+13-LTS easiest way to find the version is from: https://api.adoptium.net/v3/info/release_versions?version=[21,22]&release_type=ga |
Do we still see this as a bug @johnoliver or an update to our docs? |
FTR, that was not fun to debug why assets could not be returned from a valid version working elsewhere with the API 😓 IMO https://api.adoptium.net/v3/assets/version/21.0.1%2B12?architecture=x64&image_type=jdk returns a 404 error |
the version in the installer path: is the release name/tag https://github.com/adoptium/temurin21-binaries/releases/tag/jdk-21.0.1%2B12 If anything this is actually a badly named path as it makes it seem like that is a version and not a name...something for v4 There is: https://api.adoptium.net/v3/assets/release_name/eclipse/... That will behave the same as the installer path as it takes a release name. Re the
The question here would be when we say an argument is a version should it be an exact match (which is how we have interpreted it to date), or introduce something more fuzzy where we effectively say "well if the user asked for 11.0.2+13, what they REALLY mean is 11.0.2+13-LTS". So there is some precedence for modifying the version style as there is the semver flag: That allows the user to specify versions as a semver rather than openjdk version. So my options would be:
|
I think I'd go for option 3 & 2 - that is, have the version_match behaviour flag but default it to the principle of least surprise where semver == semver-LTS for GA releases. |
I tend to disagree with that approach @karianna , I think the API usage should be data-driven and users should not presume or assume the values in the API URLs. The API users (programs/scripts/etc) should be reactive to the results obtained from earlier root API queries. Of course, documenting the behavior of the APIs and explaining their structure is good so that the APIs used to achieve a task are navigable. I'm not a fan of aliases or fuzzy matching API URLs. So when the original post says (and I paraphrase), "21.0.2+13 is listed on the website" so I tried "https://api.adoptium.net/v3/assets/version/21.0.2+13" and it doesn't work, I think that is flawed logic. Don't guess a URL based on the website display, use the supplied info/release_versions API to get the list, and so on. Our documentation is lacking for the API for sure. |
Yeah it's a tough one, we could update the docs for sure as a starting point and see how many people still trip after that (which would tell me our design is not intuitive to use). |
The
/v3/assets/version
endpoint does not work for the latest21.0.2+13
release:21.0.2+13
is listed on the website:https://adoptium.net/en-GB/temurin/releases/?version=21&package=any
The endpoint does however work for previous releases
The text was updated successfully, but these errors were encountered: